GX_ENUM(x):possible wrong assignement

By andale8592, 24 September, 2025
Forums
Gurux DLMS for ANSI C

Hi,
i notice that: #define GX_ENUM(X) GX_UNION(&X, cVal, DLMS_DATA_TYPE_ENUM), in https://github.com/Gurux/GuruxDLMS.c/blob/master/development/include/va…
I think that should be: #define GX_ENUM(X) GX_UNION(&X, bVal, DLMS_DATA_TYPE_ENUM), (like in https://github.com/Gurux/GuruxDLMS.c/blob/master/development/src/varian…).
Moreover the DLMS Blue Book specification states the enum should range [0,255].

Thanks,
Alessandro

Kurumi

2 months 1 week ago

Hi Alessandro,

That doesn't affect anything. The byte where the value is saved is the same.

I understand your concern, however, and this will change for the next release.

BR,
Mikko

andale8592

2 months 1 week ago

Thank you Mikko, also for GX_STRUCT in similar way, in my opinioni, should be:

#define GX_STRUCT(X, VALUE_) GX_UNION2(&X, Arr= &VALUE_, (DLMS_DATA_TYPE)(DLMS_DATA_TYPE_BYREF | DLMS_DATA_TYPE_STRUCTURE), 0, 0) instead of pVal = &Arr.
I know is the same, but from a developer point of view kown that the strcuture is implemented as a variantArray is more transparent.

Thanks,
Alessandro

andale8592

2 months 1 week ago

Thank you Mikko, also for GX_STRUCT in similar way, in my opinioni, should be:

#define GX_STRUCT(X, VALUE_) GX_UNION2(&X, Arr= &VALUE_, (DLMS_DATA_TYPE)(DLMS_DATA_TYPE_BYREF | DLMS_DATA_TYPE_STRUCTURE), 0, 0) instead of pVal = &Arr.
I know is the same, but from a developer point of view kown that the strcuture is implemented as a variantArray is more transparent.

Thanks,
Alessandro